Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded examples cleanup #30330

Merged
merged 6 commits into from
Mar 4, 2020
Merged

Embedded examples cleanup #30330

merged 6 commits into from
Mar 4, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Mar 3, 2020 •
edited
Loading

Few visual tweaks to our docs' embedded examples and code snippets:

  • Thinner, darker border around the demo
  • Removed margin-bottom on all :last-child within
  • Tightened vertical padding on .highlight on desktop viewports
  • Fixed a busted class
  • Nested more CSS

Screen Shot 2020-03-03 at 3 37 12 PM

@mdo mdo requested a review from a team as a code owner March 3, 2020 23:55
@ysds ysds merged commit 50c95d9 into master Mar 4, 2020
@ysds ysds deleted the examples-cleanup branch March 4, 2020 12:32
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@mdo @MartijnCuppens @olsza
Embedded examples cleanup (twbs#30330)
61d2b74 
* Thin out embedded examples borders, rounded their corners
* Fix busted class
* Adjust nesting of .bd-example styles, tweak padding while I'm at it
* combine selectors
* cleanup some margins that always cancel each other out
* Remove redundant universal selector

Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysds ysds ysds approved these changes

Assignees
No one assigned
Labels
css docs no-backport-to-v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdo @ysds @MartijnCuppens