Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix navbar-nav-scroll description #32846

Merged
merged 1 commit into from
Jan 20, 2021
Merged

docs: Fix navbar-nav-scroll description #32846

merged 1 commit into from
Jan 20, 2021

Conversation

kyletsang
Copy link
Contributor

Docs say to add .navbar-nav-scroll to the .navbar-collapse element, but the example actually adds it to the .navbar-nav element instead.

This PR corrects the docs text.

mdo
mdo approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth on this—either works for me, but probably best that it all matches with the example :). Thanks!

@XhmikosR XhmikosR merged commit c6d6160 into twbs:main Jan 20, 2021
@kyletsang kyletsang deleted the docs/navbar-nav-scroll-fix branch January 20, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
docs v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyletsang @mdo @XhmikosR