Convert buttons to CSS variables #34600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
force-pushed
the
css-vars-btn
branch
3 times, most recently
from
34d2052
to
03a8e7f
Compare
XhmikosR
force-pushed
the
css-vars-btn
branch
from
ae6ad05
to
8dbe58a
Compare
This was referenced Sep 8, 2021
|
Per #34435, we may want to migrate this back to v4 with a separate PR to fix in Sass. |
This comment has been minimized.
This comment has been minimized.
XhmikosR
force-pushed
the
css-vars-btn
branch
from
3967923
to
1f31212
Compare
XhmikosR
reviewed
Oct 29, 2021
2 tasks
mdo
force-pushed
the
css-vars-btn
branch
3 times, most recently
from
65327f0
to
c8733b6
Compare
ffoodd
reviewed
Dec 7, 2021
|
Outline button has no disabled border color variable. |
mdo
force-pushed
the
css-vars-btn
branch
2 times, most recently
from
a51a830
to
81ae9bb
Compare
|
This PR should be in even better shape than before. I've just pushed a few more changes to migrate all of Bootstrap's docs buttons to CSS variables, renamed and cleaned up a few things, and added an example of our custom buttons via CSS variables to the buttons docs page. Let me know how you're feeling about this all @ffoodd, would love your eyes on it :). |
ffoodd
approved these changes
Feb 14, 2022
- Use CSS variables wherever possible - Rename purple-bright to violet for brevity, add CSS vars versions - Rename download to accent
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos:
gradient()mixins. Nothing to figure out, we're good to go!border-radiusproperty vs@include border-radius(). Dropped the mixin here and am using a fallback value in the CSS variable given thevalid-radius()function.font-size()mixin from thebutton-size()mixin and default.btnvalue. It doesn't seem to matter comparing this PR to main..btn-linkBiggest concern for all these PRs will be compiled file size of our CSS. Looking at the bootstrap.css diff though:
This will change a bit once:focusstyles are restored.Preview: https://deploy-preview-34600--twbs-bootstrap.netlify.app/docs/5.1/components/buttons/