Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a few eslint-config-xo rules #34620

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Enable a few eslint-config-xo rules #34620

merged 1 commit into from
Jul 29, 2021

Conversation

XhmikosR
Copy link
Member

  • unicorn/prefer-dom-node-append
  • unicorn/prefer-dom-node-remove

These are supported by our supported browsers.

* unicorn/prefer-dom-node-append
* unicorn/prefer-dom-node-remove
@XhmikosR XhmikosR marked this pull request as ready for review July 29, 2021 15:28
@XhmikosR XhmikosR requested a review from a team as a code owner July 29, 2021 15:28
Copy link
Contributor

@alpadev alpadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpadev alpadev merged commit 6d707f4 into main Jul 29, 2021
@alpadev alpadev deleted the main-xmr-js-lint branch July 29, 2021 22:23
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request Aug 18, 2021
* unicorn/prefer-dom-node-append
* unicorn/prefer-dom-node-remove
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants