Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for dart sass compile error #35033

Merged
merged 3 commits into from Oct 5, 2021

Conversation

kyletsang
Copy link
Contributor

@kyletsang kyletsang commented Sep 21, 2021

There appears to be an issue with dart sass in a basic create-react-app project where it fails to compile. This was originally reported here:
react-bootstrap/react-bootstrap#6039

Dart sass has issues parsing the negative margin values in the make-row mixin.

As a workaround, we can put the negative value in front of the var when doing the multiplication, and this will allow the production build to compile

Fixes #35018

@kyletsang kyletsang requested a review from as a code owner Sep 21, 2021
@GeoSot GeoSot requested review from ffoodd and mdo Sep 24, 2021
@GeoSot GeoSot added this to In progress in v5.1.2 via automation Sep 24, 2021
ffoodd
ffoodd approved these changes Sep 24, 2021
Copy link
Member

@ffoodd ffoodd left a comment

I'm a bit concerned about applying such patch in a single place, but if that works 🤷

We may add a comment to mention the bug / issue.

@XhmikosR
Copy link
Member

XhmikosR commented Sep 29, 2021

@mdo this seems to be related to #35011 too. I wonder if there are more places?

@XhmikosR
Copy link
Member

XhmikosR commented Sep 30, 2021

This is not an issue with dart sass, it's shellscape/postcss-values-parser#138.

@XhmikosR XhmikosR merged commit a2aa8c5 into twbs:main Oct 5, 2021
6 checks passed
v5.1.2 automation moved this from Ready to merge to Done Oct 5, 2021
ilunglee added a commit to CMDBrew/adminterface that referenced this issue Nov 2, 2021
This includes the workaround for dart sass compile error. See twbs/bootstrap#35033
ilunglee added a commit to CMDBrew/adminterface that referenced this issue Nov 2, 2021
This includes the workaround for dart sass compile error. See twbs/bootstrap#35033
ilunglee added a commit to CMDBrew/adminterface that referenced this issue Nov 2, 2021
This includes the workaround for dart sass compile error. See twbs/bootstrap#35033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.1.2
  
Done
Development

Successfully merging this pull request may close these issues.

5 participants