Nested dropdowns #35891
Draft
Nested dropdowns #35891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .dropdown > .dropdown-item:hover ~ .dropdown-menu { | ||
| position: absolute; | ||
| top: 0; | ||
| left: calc(100% - .25rem); // stylelint-disable-line function-disallowed-list |
There was a problem hiding this comment.
hmm.. why not just use right: 0? but better solution is detect position in js - if menu near right side, then submenu must be displayind at left.
| } | ||
| } | ||
|
|
||
| .dropdown .dropdown-menu:hover, |
There was a problem hiding this comment.
what's about other direction classes (.dropup and etc.)?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is heavily WIP and will need some JS work to make it perfect. Mobile behavior will be crucial IMO and ultimately makes or breaks this entire effort. This PR adds some basic submenu positioning (not with Popper) and displaying via CSS.
Here's how we'd need to do it right:
Would love to hear from @twbs/js-review and the rest of the team on doing this.