Use all dropdowns CSS variables #35907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
approved these changes
Feb 25, 2022
mdo
force-pushed
the
main-jd-fix-dropdowns-css-variables
branch
from
90f7c92
to
a0aadf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a proposal to use all dropdowns CSS variables available:
--#{$variable-prefix}dropdown-inner-border(that probably needed to be renamed in--#{$variable-prefix}dropdown-inner-border-radiussince it is based on$dropdown-inner-border-radius)--#{$variable-prefix}dropdown-divider-margin-yMotivation & Context
--#{$variable-prefix}dropdown-inner-borderand--#{$variable-prefix}dropdown-divider-margin-ywere not used in the_dropdown.scssfile.Types of changes
Checklist
npm run lint)My change introduces changes to the documentationI have updated the documentation accordinglyI have added tests to cover my changesRelated issues
N/A
Live preview