Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new example in examples/features page. #36660

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Added new example in examples/features page. #36660

merged 3 commits into from
Aug 4, 2022

Conversation

thevipinmishra
Copy link
Contributor

@thevipinmishra thevipinmishra commented Jul 3, 2022

Added a new example on examples page - in the features section.

Live preview

@julien-deramond
Copy link
Member

julien-deramond commented Jul 3, 2022

Before starting a code review, do you consider this new example acceptable in terms of design @mdo?

@thevipinmishra
Copy link
Contributor Author

thevipinmishra commented Jul 3, 2022

Before starting a code review, do you consider this new example acceptable in terms of design @mdo?

Is there any guideline for the examples that can get accepted? In terms of design? 🙂

I'm thinking about adding a few more examples.

site/content/docs/5.2/examples/features/features.css Outdated Show resolved Hide resolved
site/content/docs/5.2/examples/features/features.css Outdated Show resolved Hide resolved
site/content/docs/5.2/examples/features/index.html Outdated Show resolved Hide resolved
site/content/docs/5.2/examples/features/index.html Outdated Show resolved Hide resolved
site/content/docs/5.2/examples/features/index.html Outdated Show resolved Hide resolved
site/content/docs/5.2/examples/features/index.html Outdated Show resolved Hide resolved
site/content/docs/5.2/examples/features/index.html Outdated Show resolved Hide resolved
site/content/docs/5.2/examples/features/index.html Outdated Show resolved Hide resolved
@mdo
Copy link
Member

mdo commented Jul 19, 2022

Always down for more example snippets! Handful of code quality and consistency things here to address first though :).

@thevipinmishra
Copy link
Contributor Author

Hey @mdo,

I've fixed all the issues you pointed out, had some issues with the .editorconfig on my VS Code but It worked out fine on Sublime Text.

Thanks a lot for reviewing this. I'm planning to contribute with more examples! 😊

@thevipinmishra
Copy link
Contributor Author

Just pushed the required changes!

Thanks for the heads up, will surely take care of this in future!

@patrickhlauke
Copy link
Member

Perfect, thank you @thevipinmishra

@mdo mdo merged commit 9e57dfa into twbs:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants