Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused --bs-focus-ring-box-shadow and add documentation for --bs-focus-ring-{x|y|blur} #38095

Merged
merged 2 commits into from
Feb 25, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 21, 2023

Description

This PR suggests removing --bs-focus-ring-box-shadow which isn't used in the code. It might be considered a read-only custom property but IMHO, it can be misunderstood to have read-only custom properties. Or we could decide at some point to name them differently so that they can be more understandable by Bootstrap users.

This PR also suggests documenting the presence of --bs-focus-ring-x, --bs-focus-ring-y, and --bs-focus-ring-blur by providing an explanation and an example.

Type of changes

  • Enhancement (non-breaking change which adds functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review February 21, 2023 20:59
@julien-deramond julien-deramond requested a review from a team as a code owner February 21, 2023 20:59
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat move! 😄

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@julien-deramond julien-deramond merged commit 51299bf into main Feb 25, 2023
@julien-deramond julien-deramond deleted the main-jd-focus-ring-enhancements branch February 25, 2023 07:01
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants