Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass warning: Handle the error directly in the function #39132

Closed
wants to merge 1 commit into from

Conversation

louismaximepiton
Copy link
Member

Description

Add a check for percentage values directly in the function so people using this function won't have any change to do.
Changed the rfs vendor as well, but it might be done on rfs side directly and backported in Bootstrap.

Motivation & Context

Deprecation warning while using percentage values in abs() function.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

Fixes #39028.
Might superseed #39030.

@louismaximepiton
Copy link
Member Author

I couldn't achieve to resolve the CI (node-sass), I'll try some more asap.

@VictorQueiroz
Copy link

VictorQueiroz commented Sep 1, 2023

This is not an issue, except for "dart-sass," and "dart-sass" is no standard or anything relevant at all. So don't waste your precious time trying to adapt this project to it.

Let's stick to node-sass and dedicate to make this project continue to be the work of art that it is.

@theodorejb
Copy link

This is not an issue, except for "dart-sass," and "dart-sass" is no standard or anything relevant at all. So don't waste your precious time trying to adapt this project to it.

Node Sass has been deprecated for almost three years, and Dart Sass is the primary implementation of Sass which is officially recommended for use (see https://sass-lang.com/dart-sass/).

@julien-deramond
Copy link
Member

As long as we want to maintain compatibility with node-sass, I'm not sure we can find a solution here. At some point (in v6?), maybe we can stop maintaining this compatibility and then land such a fix within the function.
For now, I'd land #39030.
Thoughts @twbs/css-review?

@louismaximepiton
Copy link
Member Author

I'm fine with this on my side. Let's try to not forget it in v6.

@julien-deramond
Copy link
Member

Closing it for now. We'll get back to it for v6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css rfs Related to RFS v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dart-sass deprecation warning: Passing percentage units to the global abs() function is deprecated.
4 participants