Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass ABS deprecation warning #460

Closed
ccasabona opened this issue Aug 28, 2023 · 2 comments
Closed

Sass ABS deprecation warning #460

ccasabona opened this issue Aug 28, 2023 · 2 comments

Comments

@ccasabona
Copy link

A recent update of the sass-embedded gem causes a deprecation warning when compiling assets. I posted this on ruby-bootstrap gem, and they referred me here.

DEPRECATION WARNING: Passing percentage units to the global abs() function is deprecated.
12:40:48 css.1   | In the future, this will emit a CSS abs() function to be resolved by the browser.
12:40:48 css.1   | To preserve current behavior: math.abs(100%)
12:40:48 css.1   | To emit a CSS abs() now: abs(#{100%})
12:40:48 css.1   | More info: https://sass-lang.com/d/abs-percent
12:40:48 css.1   | 
12:40:48 css.1   |    ╷
12:40:48 css.1   | 57 │   $dividend: abs($dividend);
12:40:48 css.1   |    │              ^^^^^^^^^^^^^^
12:40:48 css.1   |    ╵
12:40:48 css.1   |     ../../../.rvm/gems/ruby-3.2.2@ruby3rails7/gems/bootstrap-5.3.1/assets/stylesheets/bootstrap/vendor/_rfs.scss 57:14         divide()
12:40:48 css.1   |     ../../../.rvm/gems/ruby-3.2.2@ruby3rails7/gems/bootstrap-5.3.1/assets/stylesheets/bootstrap/mixins/_grid.scss 59:12        row-cols()
12:40:48 css.1   |     ../../../.rvm/gems/ruby-3.2.2@ruby3rails7/gems/bootstrap-5.3.1/assets/stylesheets/bootstrap/mixins/_grid.scss 85:13        @content
12:40:48 css.1   |     ../../../.rvm/gems/ruby-3.2.2@ruby3rails7/gems/bootstrap-5.3.1/assets/stylesheets/bootstrap/mixins/_breakpoints.scss 68:5  media-breakpoint-up()
12:40:48 css.1   |     ../../../.rvm/gems/ruby-3.2.2@ruby3rails7/gems/bootstrap-5.3.1/assets/stylesheets/bootstrap/mixins/_grid.scss 72:5         make-grid-columns()
12:40:48 css.1   |     ../../../.rvm/gems/ruby-3.2.2@ruby3rails7/gems/bootstrap-5.3.1/assets/stylesheets/bootstrap/_grid.scss 38:3                @import
12:40:48 css.1   |     _bootstrap.scss 20:9                                                                                                       @use
12:40:48 css.1   |     app/assets/stylesheets/application.scss 60:1                                                                               root stylesheet

Ruby 3.2
Rails 7.0.7

@julien-deramond
Copy link
Member

julien-deramond commented Aug 28, 2023

I'm not entirely sure there's something to do in this twbs/rfs project for the divide function. In twbs/bootstrap#39030, for the moment, we changed only the way the function is called and not the function itself.

@twbs/css-review thoughts?

Edit: another approach in twbs/bootstrap#39132

@MartijnCuppens
Copy link
Member

This should be fixed with twbs/bootstrap#39030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants