Enforce focus for most recent modal only, fixes #4781 (even though it has been closed already)

[everilae]

In my opinion the focus grabbing browser crash in Firefox is not acceptable, even if showing multiple modals is bad UI behaviour.

[andrewdeandrade]

Hey @everilae,

Thanks for opening this pull-request! Unfortunately, it looks like it fails to pass the criteria neccessary for submitting to bootstrap. The following things are currently failing:

• should always be made against -wip branches
• should always be made from feature branches
• should always include a unit test if changing js files

For a full list of issue filing guidelines, please refer to the bootstrap issue filing guidelines.

thanks!

[stephankaag]

Made a new pull request @ #5833

[fat]

don't want to keep track of all the modals in memory – this seems very inefficient, particularly at an instance level

[everilae]

Though I've given up on this a long ago (implemented the fix locally), doesn't the code as it is now store references in an array? The modals are "in memory" already through jq data binding to elements. No big loss there, if I've understood anything.

If inefficient at any point, then at the inArray perhaps. But the idea wasn't to pop up 100 modals, but allow a few errors to overlap. Even 10 error dialogs overlapping would mean that everything has gone to hell anyway, at least in our case.

Also the store is temporary, since the instance references are spliced away on hide. Did "all modals in memory" perhaps mean that this part was missed?