Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Wrench adjustable circle typo #1198

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fixed Wrench adjustable circle typo #1198

merged 1 commit into from
Feb 8, 2022

Conversation

biutas
Copy link
Contributor

@biutas biutas commented Feb 3, 2022

Fixes #1186

@korki43
Copy link
Contributor

korki43 commented Feb 3, 2022

You should probably also change the filenames, or the icons will be regenerated using the wrong name.

Also: There is some inconsistency about how renaming icons is handled.
@mdo said that renaming icons needs a major version bump (#843 (comment)), but there are still some icons which were renamed in patches (#1119).

IMO: Renaming is a major change, but we might have to make an exception for typos, especially to stay consistent with #1119.

@biutas
Copy link
Contributor Author

biutas commented Feb 4, 2022

Oh, I forgot about filenames. Just updated right now.

About the consistency, @mdo, added the issue #1186 to be released on 1.8.1, maybe because it's a typo, not a name change.

mdo
mdo approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a typo, vs a change in filename structure, going to merge.

@mdo mdo force-pushed the wrench-adjustable-circle-typo branch from 6814067 to 28f5426 Compare February 8, 2022 04:32
@biutas @mdo
Fix wrench-adjustable-circle typo
8dcd9bd 
Co-Authored-By: Gabriel Lopes <biutas@hotmail.com>
@mdo mdo force-pushed the wrench-adjustable-circle-typo branch from 28f5426 to 8dcd9bd Compare February 8, 2022 04:34
@mdo mdo merged commit 27d1e4d into twbs:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrench Adjustable Circle Typo
3 participants
@biutas @korki43 @mdo