Fix unitless bug

twbs · Oct 13, 2018 · 35f9482 · 35f9482
1 parent 94886c7
commit 35f9482
Show file tree

Hide file tree

Showing 8 changed files with 28 additions and 8 deletions.
diff --git a/examples/postcss/gulp/dest/main.css b/examples/postcss/gulp/dest/main.css
@@ -64,5 +64,10 @@
 
 /* responsive-font-size property without unit */
 .selector-8 {
-  font-size: 32;
+  font-size: 2rem;
+}
+@media (max-width: 1200px) {
+  .selector-8 {
+  font-size: calc(1.2rem + 1.066667vw);
+  }
 }
diff --git a/examples/postcss/node/dest/main.css b/examples/postcss/node/dest/main.css
@@ -64,5 +64,10 @@
 
 /* responsive-font-size property without unit */
 .selector-8 {
-  font-size: 32;
+  font-size: 2rem;
+}
+@media (max-width: 1200px) {
+  .selector-8 {
+  font-size: calc(1.2rem + 1.066667vw);
+  }
 }
diff --git a/examples/stylus/gulp/dest/main.css b/examples/stylus/gulp/dest/main.css
@@ -57,5 +57,10 @@
 }
 /* responsive-font-size property without unit */
 .selector-8 {
-  font-size: 32;
+  font-size: 2rem;
+}
+@media (max-width: 1200px) {
+  .selector-8 {
+    font-size: calc(1.2rem + 1.066666666666667vw);
+  }
 }
diff --git a/examples/stylus/node/dest/main.css b/examples/stylus/node/dest/main.css
@@ -57,5 +57,10 @@
 }
 /* responsive-font-size property without unit */
 .selector-8 {
-  font-size: 32;
+  font-size: 2rem;
+}
+@media (max-width: 1200px) {
+  .selector-8 {
+    font-size: calc(1.2rem + 1.066666666666667vw);
+  }
 }
diff --git a/postcss/rfs.js b/postcss/rfs.js
@@ -69,7 +69,7 @@ module.exports = postcss.plugin('postcss-rfs', function (opts) {
         decl.prop = 'font-size';
 
         // Skip if value is not in px or rem
-        if (!new RegExp(/(\d*\.?\d+)(px|rem)/g).test(decl.value)) {
+        if (isNaN(decl.value) && !new RegExp(/(\d*\.?\d+)(px|rem)/g).test(decl.value)) {
           return;
         }
 

diff --git a/sass/_rfs.sass b/sass/_rfs.sass
@@ -64,7 +64,7 @@ $rfs-breakpoint-unit: unit($rfs-breakpoint)
   $rfs-suffix: if($important, " !important", "")
 
   // If $fs isn't a number (like inherit) or $fs has a unit (not px or rem, like 1.5em) or $ is 0, just print the value
-  @if not $fs-unit or not $fs-unit != "" and $fs-unit != "px" and $fs-unit != "rem" or $fs == 0
+  @if not $fs-unit or $fs-unit != "" and $fs-unit != "px" and $fs-unit != "rem" or $fs == 0
     font-size: #{$fs}#{$rfs-suffix}
   @else
     // Variables for storing static and fluid rescaling

diff --git a/scss/_rfs.scss b/scss/_rfs.scss
@@ -69,7 +69,7 @@ $rfs-breakpoint-unit: unit($rfs-breakpoint);
   $rfs-suffix: if($important, " !important", "");
 
   // If $fs isn't a number (like inherit) or $fs has a unit (not px or rem, like 1.5em) or $ is 0, just print the value
-  @if not $fs-unit or not $fs-unit != "" and $fs-unit != "px" and $fs-unit != "rem" or $fs == 0 {
+  @if not $fs-unit or $fs-unit != "" and $fs-unit != "px" and $fs-unit != "rem" or $fs == 0 {
     font-size: #{$fs}#{$rfs-suffix};
   }
   @else {

diff --git a/stylus/rfs.styl b/stylus/rfs.styl
@@ -55,7 +55,7 @@ rfs($fs, $important = false)
     $rfs-suffix = !important
 
   // If $fs isn't a number (like inherit) or $fs has a unit (not px or rem, like 1.5em) or $ is 0, just print the value
-  if type-of($fs) != "unit" or (unit($fs) != "px" and unit($fs) != "rem") or $fs == 0
+  if type-of($fs) != "unit" or (unit($fs) != "" and unit($fs) != "px" and unit($fs) != "rem") or $fs == 0
     font-size: "%s%s" % ($fs  $rfs-suffix)
   else
     // Variables for storing static and fluid rescaling