Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out the "combining modifications" idiom #336

Closed
Niols opened this issue Mar 14, 2023 · 0 comments · Fixed by #338
Closed

Factor out the "combining modifications" idiom #336

Niols opened this issue Mar 14, 2023 · 0 comments · Fixed by #338
Assignees

Comments

@Niols
Copy link
Member

Niols commented Mar 14, 2023

Both the malformDatumTweak and the doubleSatAttack share a helper function, allCombinations, written twice in the same way independently. This suggests that there is an idiom behind for combining modification (of outputs in particular). We should factor it out of those tweaks/attacks and into common utilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants