-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flake #164
Fix flake #164
Conversation
Without this, it was possible to importer the jupyterWith attribute without its python and haskell overlays, thus ending up with errors like error: attribute 'jupyter_contrib_core' missing
jupyterWith is an attrset so let's not use it as a package
Thanks for the PR, I'm not very experienced with Flakes yet, this is useful. I launched tests. I have the impression that the changes to the two overlay files are superficial, can you keep the original? @GTrunSec Since you wrote the Flake, can you take a look at the PR? |
I will look into the CI failure. One cool tool though is https://github.com/edolstra/flake-compat/ that allows to run a legacy nix-shell while using the flake as a source of truth (mentioning this since I see the failing job comes from a devshell.nix). |
I fixed the example flake, should be good now. |
This is working now, thank you! |
I'm running into this issue (an error about
I'm not sure if the issue is in the way I import |
looks good, thanks for your work. |
I've tried using the flake in my project referencing jupyterWith.overlay but it failed with
error: attribute 'jupyter_contrib_core' missing
.I fixed that and made it pass
nix flake check
. There is a breaking change though.