Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure jupyterlab to open url in browser instead of redirect file #386

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

k1nkreet
Copy link
Contributor

@k1nkreet k1nkreet commented Dec 2, 2022

Fix for #368. Use jupyter configuration file to disable use_redirect_file-option and fallback to old opening localhost URL in browser behavior

@k1nkreet k1nkreet requested a review from garbas as a code owner December 2, 2022 14:35
@k1nkreet k1nkreet requested a review from djacu December 2, 2022 14:36
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

@github-actions github-actions bot temporarily deployed to pull request December 2, 2022 14:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 2, 2022 14:51 Inactive
Copy link
Collaborator

@djacu djacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garbas garbas merged commit 1d6d6ec into main Dec 6, 2022
@garbas garbas deleted the ip/use-url-intead-of-file branch December 6, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants