Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving pipes dependency to separate library? #260

Open
turion opened this issue Feb 16, 2023 · 4 comments
Open

Consider moving pipes dependency to separate library? #260

turion opened this issue Feb 16, 2023 · 4 comments

Comments

@turion
Copy link
Collaborator

turion commented Feb 16, 2023

Right now, when one wants to install monad-bayes, it pulls in pipes as a dependency, and with that many other dependencies completely unrelated to monad-bayes. I'd recommend splitting out the parts that use pipes (I think it's just a streaming example?) into a separate library monad-bayes-pipes in the same repository. That way, the dependency tree of monad-bayes is much more lightweight, which makes it easier for other to use it.

@turion
Copy link
Collaborator Author

turion commented Feb 16, 2023

@reubenharry what do you think about that?

@reubenharry
Copy link
Contributor

That's fine with me. Especially now that rhine-bayes exists, the streaming stuff is not so important. I think the docs may mention the tui, which uses mcmcP, but other than that, I think splitting it out should be straightforward.

@turion
Copy link
Collaborator Author

turion commented Jun 13, 2023

How about the following proposed directory structure:

  • monad-bayes: Main library, containing src, test, benchmark, models, monad-bayes.cabal
  • monad-bayes-pipes: All parts that also have pipes as a dependency

@reubenharry
Copy link
Contributor

Fine with me, although if it requires more than a little work, it seems to me like not a good use of time, since monad-bayes is unlikely to have many users beyond us. Note btw that the notebooks have a wide variety of dependencies, and those are separated, using nix, from the main dependencies of monad-bayes. Perhaps the pipes examples could just be put in notebooks too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants