Skip to content

Commit

Permalink
Don't leak memory in background eval (#1869)
Browse files Browse the repository at this point in the history
* Run a separate process for each background evaluation job

* Send over only the dependencies, not everything

* Remove ipc-channel

* Kill the child process if it times out

* Add some comments
  • Loading branch information
jneem committed Mar 26, 2024
1 parent 5d3b244 commit 1caa77e
Show file tree
Hide file tree
Showing 6 changed files with 202 additions and 313 deletions.
69 changes: 1 addition & 68 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ git-version = "0.3.5"
indexmap = "1.9.3"
indoc = "2"
insta = "1.29.0"
ipc-channel = "0.18.0"
js-sys = "0.3"
lalrpop = "0.19.9"
lalrpop-util = "0.19.9"
Expand All @@ -77,6 +76,7 @@ pyo3-build-config = "0.17.3"
regex = "1"
rustyline = "11.0"
rustyline-derive = "0.8.0"
scopeguard = "1.2.0"
serde = "1.0.164"
serde_json = "1.0.96"
serde_repr = "0.1"
Expand Down
2 changes: 1 addition & 1 deletion lsp/nls/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ crossbeam.workspace = true
csv.workspace = true
derive_more.workspace = true
env_logger.workspace = true
ipc-channel.workspace = true
lalrpop-util.workspace = true
lazy_static.workspace = true
log.workspace = true
lsp-server.workspace = true
lsp-types.workspace = true
nickel-lang-core.workspace = true
regex.workspace = true
scopeguard.workspace = true
serde = { workspace = true, features = ["derive"] }
serde_json.workspace = true
thiserror.workspace = true
Expand Down

0 comments on commit 1caa77e

Please sign in to comment.