Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile benchmarks via Nix #1119

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Compile benchmarks via Nix #1119

merged 4 commits into from
Feb 16, 2023

Commits on Feb 13, 2023

  1. ci: compile benchmarks via nix

    @asymmetric
    asymmetric committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    4cdc71c View commit details
    Browse the repository at this point in the history

  2. flake: separate benchmark compilation and running 

    This allows compiling them often in CI (since it's fast), and
benchmarking less often.
    @asymmetric
    asymmetric committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    7c9cb38 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. flake: clean up benchmarks invocation 

    Instead of overriding the buildPhase, we use a function argument with optional string appending.
    @asymmetric
    asymmetric committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    f55e6f4 View commit details
    Browse the repository at this point in the history

  2. flake: remove doCheck in benchmarks package 

    The default check phase has no side effects, so no need to disable it.

Cf. https://crane.dev/API.html#optional-attributes-11
    @asymmetric
    asymmetric committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    bd88092 View commit details
    Browse the repository at this point in the history