Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LSP crash when a resolved import term fails to typecheck #1191

Merged
merged 11 commits into from
Mar 30, 2023
Merged

Fix LSP crash when a resolved import term fails to typecheck #1191

merged 11 commits into from
Mar 30, 2023

Commits on Mar 27, 2023

  1. Handle typechecking error from imports resolution.

    @ebresafegaga
    ebresafegaga committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    62ea376 View commit details
    Browse the repository at this point in the history

  2. Use more a accurate position and handle all imports

    @ebresafegaga
    ebresafegaga committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    9f0c74a View commit details
    Browse the repository at this point in the history

  3. Persist diagnostics

    @ebresafegaga
    ebresafegaga committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    4dce01a View commit details
    Browse the repository at this point in the history

  4. Avoid unnecessary clone

    @ebresafegaga
    ebresafegaga committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    5c4453e View commit details
    Browse the repository at this point in the history

  5. Final clean up & fix clippy errors

    @ebresafegaga
    ebresafegaga committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    dd1c0fd View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Revert "Final clean up & fix clippy errors" 

    This reverts commit dd1c0fd.
    @ebresafegaga
    ebresafegaga committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    4f8fd28 View commit details
    Browse the repository at this point in the history

  2. Revert "Avoid unnecessary clone" 

    This reverts commit 5c4453e.
    @ebresafegaga
    ebresafegaga committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    0302ba5 View commit details
    Browse the repository at this point in the history

  3. Revert "Persist diagnostics" 

    This reverts commit 4dce01a.
    @ebresafegaga
    ebresafegaga committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    d080fa9 View commit details
    Browse the repository at this point in the history

  4. Revert "Use more a accurate position and handle all imports" 

    This reverts commit 9f0c74a.
    @ebresafegaga
    ebresafegaga committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    77c7347 View commit details
    Browse the repository at this point in the history

  5. Revert "Handle typechecking error from imports resolution." 

    This reverts commit 62ea376.
    @ebresafegaga
    ebresafegaga committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    e72bced View commit details
    Browse the repository at this point in the history

  6. Don't unwrap the typechecking of import terms 

    If it doens't type check correctly, it shouldn't affect the current file.
    @ebresafegaga
    ebresafegaga committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    100d1b5 View commit details
    Browse the repository at this point in the history