New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit stdlib documentation #1196
Conversation
94bde75
to
0de20b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I had to stop at some point with suggestions, there were just too many lines 😓 but I think we should be consistent over:
- verbal forms. If we start some documentation with
Returns
, then all verbs describing the action of a function should use thes
form. - indentation. I believe there are cases where the code is indented with respect to the block fences, but not everywhere. Also, I don't think it's standard practice, it feels like it should start the the same level as the block, as I don't see much usefulness in having the whole code block indented by one level from the leftmost boundary.
No worries 😆 I'll find all the lines.
👍
It always felt to me like a fenced in block acts like a new scope, and as such deserves to be indentend. But that may indeed just be me. I'll make another pass over all of it, remove indents from code block and pay attention to the verbal forms. |
Sorry if my suggestions sounded a bit too affirmative 😅 I'm not necessarily pushing for the trailing |
So with respect to indenting code, it seems like GitHub's documentation and W3C's documentation show examples where the code isn't indented indeed (starts at the same indentation as the fence). |
No worries 😺 As you can tell from me preferring the trailing "s" on one day and preferring the other form on the next, I don't have a stable preference on the matter. But with you we have a slight bias towards trailing "s", so I'm taking that. |
0de20b2
to
af91816
Compare
9ac616e
to
897e9e4
Compare
Oh my, I've merged #1198, which might make this rebase quite difficult. Might be simpler in the end to revert, merge this one, and reformat afterward? Or do you think it'll be manageable? |
897e9e4
to
39f9186
Compare
Consistently use markdown heading for examples Consistently use third-person in stdlib docs Adjust documentation string indentation in stdlib Contract to enforce -> Enforces NumLiteral -> NumberLiteral
3c8bfd2
to
7d33e2a
Compare
For now, a quick pass over the stdlib documentation for consistency and typos.