Destructuring #473
Merged
Destructuring #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugged... probably due to a gramar issue
now it's in the correct order as described in the issue
Also added the default (`?`) in the gramar but ignored by the interpreter
works, should be tested (add cases in the testsuite)
…inded by previous matches
now `fold` the matches. Code is cleaner and a bit more efficiant
…nested patterns encontred
NOTE: new dev dependancy (duplicate) to avoid duplication of code in the test suite. Check `tests/destructuring.rs` for an example.
yannham
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
LGTM globally, but I left a good chunk of comments and nitpicks. Also, your tests always start with an empty line, for some reason.
The more I think about it, and the more I imagine we will want to have strict checks instead of relying on lazy contracts for pattern matching, for early error reporting. But we decided to go this route because this was easier, and for now, this will do.
cleaning - doc clarification - remove useless `.clone()` - Mor clear name for `QuestionMark` tocken Co-authored-by: Yann Hamdaoui <yann.hamdaoui@gmail.com>
- Doc improvements. - Code cleaning. - Drop some useless values clones. - rename `drop_fields` to `bind_open_field` more meaningfull name
simply added as `Dyn`
now a top level let can not be a `Pattern` anymore. if you write a pattern, the repl wil wait for the folowing part of a standart `let ... = ... in ...` expression. Also clean the metavalue generation for default annot.
…s arm can actualy be reached.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate to #81
Full implementation of the record destructuring as described in #81 . The list destructuring is not implemented yet.
Typechecking is not performed at this time. will be done in future PR