Feature/funargs destructuring #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, because this transformation is done in a top down pass, we don't have to be recursive or to transform generated `LetPattern`s anymore
yannham
approved these changes
Jan 12, 2022
| RichTerm::new( | ||
| Term::Fun( | ||
| x.clone(), | ||
| Term::LetPattern(None, pat, Term::Var(x).into(), t_).into(), |
There was a problem hiding this comment.
We are losing quite a few positions here. It can be a problem for error reporting. I guess we can't have a meaningful position for Var(x), but maybe the LetPattern show have the same position as the function body, I imagine this is what we do in the share_normal_form pass
There was a problem hiding this comment.
I'm not sure. because, exept for the actual body of the function, for a multiparams function, the pos is same as the main function. So should we not preferably put the rt.pos than the t_.pos?
fix comments typo and nickel syntax cleaning Co-authored-by: Yann Hamdaoui <yann.hamdaoui@gmail.com>
also add a todo to remember to check if the herited position is the good one.
This was referenced Jan 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement destructuring for functions arguments as described in the last point of #81: