Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename lists to arrays #622

Merged
merged 1 commit into from Mar 2, 2022
Merged

Rename lists to arrays #622

merged 1 commit into from Mar 2, 2022

Conversation

yannham
Copy link
Member

@yannham yannham commented Feb 23, 2022 •
edited

Depends on #620. Fix #533.

@github-actions github-actions bot temporarily deployed to pull request February 23, 2022 15:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 23, 2022 15:52 Inactive
This was referenced Feb 24, 2022
Merged
Merged
@github-actions github-actions bot temporarily deployed to pull request February 25, 2022 11:45 Inactive
@francois-caddet
Copy link
Contributor

francois-caddet commented Feb 25, 2022 •
edited

If it deppend on #620 why to name it arrays with the s? I'm not sure git will manage it as we want anyway.

@yannham
Copy link
Member Author

yannham commented Feb 25, 2022

Yeah, the title is misleading, sorry. It's renaming list to array, there is no s.

@francois-caddet
Copy link
Contributor

In the diff, right now, I have s everywhere. Probably because #620 is not merged.

Base automatically changed from task/rename-stdlib-modules-2 to master February 25, 2022 13:44
@dpulls
Copy link

dpulls bot commented Feb 25, 2022

🎉 All dependencies have been resolved !

@yannham
Copy link
Member Author

yannham commented Feb 25, 2022 •
edited

There are of course still plural arrays in the codebase, and that's ok: name of benches, plural sentences in the documentation, etc. This branch was already based onto #620, so #620 being merged or not shouldn't make a difference. This PR does use the singular array for the stdlib module, which is what matters. If there are individual mistakes, could you please point at them directly with a review comment, to make the fix easier? Thanks!

@yannham yannham force-pushed the task/rename-stdlib-modules branch from 2dd3974 to 879856c Compare March 2, 2022 15:54
@yannham yannham added the merge-queue merge on green CI label Mar 2, 2022
@github-actions github-actions bot temporarily deployed to pull request March 2, 2022 15:58 Inactive
@yannham yannham merged commit 0b15936 into master Mar 2, 2022
@yannham yannham deleted the task/rename-stdlib-modules branch March 2, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francois-caddet francois-caddet francois-caddet approved these changes

Assignees
No one assigned
Labels
merge-queue merge on green CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename List to Array or Vector
2 participants
@yannham @francois-caddet