WIP: Some chanages to content-addressed derivations RFC #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I prefer verb as function name.
This was referenced Mar 14, 2020
|
We can merge https://github.com/tweag/rfcs/pull/5/files first to clean up the diff. |
|
OK wiggled the base branch so this now shows the less messy diff. |
Ericson2314
changed the title
|
I've found more issues/subtitles as I've begun implementing. I should get a little further than come back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is sadly quite messy, but most of that can be annoyed:
Merged in latest
masterto grab change in RFC template.Renamed the
derivedfunction toderive, as I think I like the verb form better.Reworked the detailed design to emphasize the commonalities between fixed-output and the new ca derivations. Among other changes I'm calling them both ca derivations, and the new ones "floating output".