Windows support for Cabal python wrapper #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann
force-pushed
the
cabal-windows
branch
from
8675c98
to
87cec43
Compare
mboes
approved these changes
Oct 23, 2019
thufschmitt
approved these changes
Oct 23, 2019
|
|
||
| def _prepare_cabal_inputs(hs, cc, unix, dep_info, cc_info, component, package_id, tool_inputs, tool_input_manifests, cabal, setup, srcs, flags, cabal_wrapper, package_database): | ||
| """Compute Cabal wrapper, arguments, inputs.""" | ||
| with_profiling = is_profiling_enabled(hs) | ||
|
|
||
| (ghci_extra_libs, env) = get_ghci_extra_libs(hs, cc_info) | ||
| env.update(**hs.env) | ||
| env["PATH"] = _make_path(hs, tool_inputs) + ":" + ":".join(unix.paths) | ||
| path_list_sep = ";" if hs.toolchain.is_windows else ":" |
There was a problem hiding this comment.
nit: You can move this to the toplevel to avoid having to repeat it
There was a problem hiding this comment.
Good point, turns out this is a good opportunity to also refactor the path separator in LD_LIBRARY_PATH, so I'll do that in a separate PR.
The execroot path can contain special characters, e.g. `\` on Windows.
Same as other paths, e.g. `LD_LIBRARY_PATH`. The reason is that Windows paths can contain ':', e.g. `C:\foo\bar`.
Use bazel_runfiles on Windows to find executables. By default Bazel does not generated symlinks to binaries in the execroot, so relative paths to executables will not work. Instead, they must be looked up in the runfiles manifest using bazel_runfiles.
To exit early if any of the `configure`, `build`, `install` steps fails.
Bazel 1.1 requires these now.
This version fixes the issue of `sh_binary`s called with upper-case `.EXE` extension not finding the actual script file. This issue was triggered by Cabal packages with `./configure` scripts, which called `cc` in 8.3 file name format.
Requires Bazel 1.1.0 on Windows
jwiegley
force-pushed
the
cabal-windows
branch
from
87cec43
to
2a775ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C:\foo\bar)cc_wrapperon Windows, see sh_binary wrapper fails on upper case letters in file extension on Windows bazelbuild/bazel#9390.networkandlanguage-con Windows - these use./configurescripts and are more problematic on Windows.