Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use_default_shell_env #1143

Merged
merged 7 commits into from Nov 15, 2019
Merged

Remove use_default_shell_env #1143

merged 7 commits into from Nov 15, 2019

Conversation

aherrmann
Copy link
Member

depends on #1136 change base branch before merging

  • Remove all instances of use_default_shell_env = True.
    Replaces them using the POSIX toolchain provided by rules_sh.
  • On Windows some tools are found in paths containing spaces, e.g. C:\Program Files\....
    This requires additional quoting in some places.

@mboes mboes self-requested a review November 14, 2019 11:02
Copy link
Member

@mboes mboes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t! Depending on whether this or #1142 gets merged first, the comment in the CI setup for the bindist case should be updated accordingly.

@aherrmann
Copy link
Member Author

Depending on whether this or #1142 gets merged first,

This PR transitively depends on #1142 through #1136

the comment in the CI setup for the bindist case should be updated accordingly.

Yes, I'll rebase and adapt the comment. Unfortunately, we cannot remove the flag, yet. @com_google_protobuf sets use_default_shell_env = True.

@mboes
Copy link
Member

mboes commented Nov 14, 2019

We should send them a PR to get them to use rules_sh. ;)

@aherrmann
Copy link
Member Author

Turns out they're not using use_default_shell_env for PATH, but for LD_LIBRARY_PATH, so rules_sh won't help there. See protocolbuffers/protobuf#2933.

@mboes
Copy link
Member

mboes commented Nov 14, 2019

I opened protocolbuffers/protobuf#6886 to propose reverting protocolbuffers/protobuf#2933.

@aherrmann aherrmann changed the base branch from rules-sh to master November 14, 2019 16:21
@aherrmann aherrmann marked this pull request as ready for review November 14, 2019 16:22
@aherrmann aherrmann added the merge-queue merge on green CI label Nov 14, 2019
@aherrmann
Copy link
Member Author

netlify got stuck. Force pushed to kick it.

@mergify mergify bot merged commit c53f7cc into master Nov 15, 2019
@mergify mergify bot deleted the default-shell-env branch November 15, 2019 09:18
@mergify mergify bot removed the merge-queue merge on green CI label Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants