Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional hie_bios output group to haskell_repl #1263

Merged
merged 5 commits into from Mar 5, 2020
Merged

Conversation

aherrmann
Copy link
Member

This allows users to configure hie-bios to use these outputs to determine GHC flags. See #1262 (WIP) for an example setup with ghcide.

  • Factors out the common flags for ghci and hie-bios in the haskell_repl implementation.
  • Factors out the GHC flags required to configure cc_wrapper to avoid duplication.
  • Creates an output group for haskell_repl that produces a file holding all relevant ghci flags for that target. (Excludes flags that are ghci specific, e.g. repl_ghci_args or flags required for -ghci-script)

A downside of this approach, compared to e.g. hrepl, is that haskell_repl targets are not generated on-the-fly but have to be defined in BUILD files. However, this is a general limitation of haskell_repl.

Copy link
Collaborator

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

haskell/cc.bzl Outdated Show resolved Hide resolved
@aherrmann aherrmann added the merge-queue merge on green CI label Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants