Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to the modern linker input API. #1437

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Migrate to the modern linker input API. #1437

merged 2 commits into from
Nov 2, 2020

Conversation

benjaminp
Copy link
Contributor

@benjaminp benjaminp commented Oct 23, 2020 •
edited
Loading

@benjaminp benjaminp force-pushed the migrate-linking branch 4 times, most recently from 54215bb to 318c530 Compare October 23, 2020 05:30
@benjaminp benjaminp marked this pull request as ready for review October 23, 2020 05:46
@mboes
Copy link
Member

mboes commented Oct 28, 2020

LGTM, but assigning @aherrmann for an additional review.

@mboes mboes requested a review from aherrmann October 28, 2020 14:44
aherrmann
aherrmann reviewed Oct 28, 2020
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Should this instance also be changed or is there a reason to keep using libraries_to_link in that case?

Did you try enabling --incompatible_require_linker_input_cc_api in .bazelrc? Would be good to check against regressions on this on CI if possible.

@benjaminp benjaminp force-pushed the migrate-linking branch 2 times, most recently from ada01e2 to 9a33859 Compare October 28, 2020 19:23
@benjaminp
Copy link
Contributor Author

Thank you!

Thank you for the review.

Should this instance also be changed or is there a reason to keep using libraries_to_link in that case?

Yes, indeed! This makes me realize I accidentally pushed an old version of my branch that didn't fix that case through a git snafu. Should be okay now.

Did you try enabling --incompatible_require_linker_input_cc_api in .bazelrc? Would be good to check against regressions on this on CI if possible.

Yes, that's how I was testing locally. I committed this to the branch now, too.

aherrmann
aherrmann approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aherrmann aherrmann mentioned this pull request Nov 2, 2020
Merged
@aherrmann
Copy link
Member

@Mergifyio rebase

@aherrmann aherrmann added the merge-queue merge on green CI label Nov 2, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2020

Command rebase: success

Branch has been successfully rebased

@mergify mergify bot merged commit 6ad9e2b into tweag:master Nov 2, 2020
@mergify mergify bot removed the merge-queue merge on green CI label Nov 2, 2020
@benjaminp benjaminp deleted the migrate-linking branch November 2, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboes mboes mboes approved these changes

@aherrmann aherrmann aherrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjaminp @mboes @aherrmann