Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of exec_tools with semantically-identical tools. #1925

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Replace use of exec_tools with semantically-identical tools. #1925

merged 1 commit into from
Aug 3, 2023

Conversation

katre
Copy link
Contributor

@katre katre commented Aug 1, 2023

Fixes #1924.

@katre katre requested a review from avdv as a code owner August 1, 2023 14:25
@avdv
Copy link
Member

avdv commented Aug 2, 2023

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2023

rebase

✅ Branch has been successfully rebased

avdv
avdv approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@avdv avdv added the merge-queue merge on green CI label Aug 2, 2023
@katre
Copy link
Contributor Author

katre commented Aug 3, 2023

I don't understand why these tests are failing (the errors aren't in tests, but in publishing to BEP). Can we deflake these or otherwise skip them?

@avdv
Copy link
Member

avdv commented Aug 3, 2023

I don't understand why these tests are failing (the errors aren't in tests, but in publishing to BEP). Can we deflake these or otherwise skip them?

Yeah, it's been a pain... and I opened an issue here. I'll merge bypassing the statuses, just don't want to make it a habit. 😉

@avdv avdv merged commit 10aaf25 into tweag:master Aug 3, 2023
25 of 28 checks passed
@mergify mergify bot removed the merge-queue merge on green CI label Aug 3, 2023
@katre katre deleted the remove-exec-tools branch August 3, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdv avdv avdv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove use of genrule.exec_tools
2 participants
@katre @avdv