rules_haskell_tests: Fix ghcide stack pointing to wrong snapshot file #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylecornec
approved these changes
May 6, 2024
The stack snapshot for GHC 9.2.8 was a symlink to the default snapshot file. So when no `GHC_VERSION` was set in the environment, it meant the default snapshot file was used, which is the one for GHC 9.2 but the default GHC version is 9.4.6. This led to an error on buildkite as `base` in GHC 9.4 was bumped to 4.17: ``` Error: Setup.hs: Encountered missing or private dependencies: base >=4.8 && <4.17 ``` Symlink the default stack snapshot files to the specific version (not the other way around).
avdv
force-pushed
the
cb/fix-default-ghc-snapshot
branch
from
01fcee7
to
94b7222
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack snapshot for GHC 9.2.8 was a symlink to the default snapshot file. So
when no
GHC_VERSIONwas set in the environment, it meant the default snapshotfile was used, but the default version is GHC 9.4.6 now.
This led to an error on buildkite as base in GHC 9.4 was bumped to 4.17:
Symlink the default stack snapshot files to the specific version (not the other way around).
Fixes #2181