Fixing bazel 0.22 incompatible changes. #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnoir
force-pushed
the
nin-bazel-22-clean
branch
6 times, most recently
from
d17f1e9
to
7d864f1
Compare
mboes
reviewed
Jan 23, 2019
picnoir
force-pushed
the
nin-bazel-22-clean
branch
from
7d864f1
to
7882077
Compare
Fixing bazel imcompatible changes, more specifically: - incompatible_bzl_disallow_load_after_statement - incompatible_depset_is_not_iterable - incompatible_depset_union - incompatible_disable_objc_provider_resources - incompatible_disallow_conflicting_providers - incompatible_disallow_data_transition - incompatible_disallow_dict_plus - incompatible_disallow_filetype - incompatible_disallow_legacy_javainfo - incompatible_disallow_load_labels_to_cross_package_boundaries - incompatible_disallow_old_style_args_add - incompatible_disallow_slash_operator - incompatible_generate_javacommon_source_jar - incompatible_merge_genfiles_directory - incompatible_no_attr_license - incompatible_no_output_attr_default - incompatible_no_support_tools_in_action_inputs - incompatible_no_target_output_group - incompatible_no_transitive_loads - incompatible_package_name_is_a_function - incompatible_range_type - incompatible_remote_symlinks - incompatible_remove_native_git_repository - incompatible_remove_native_http_archive - incompatible_remove_native_maven_jar - incompatible_static_name_resolution - incompatible_strict_action_env
picnoir
force-pushed
the
nin-bazel-22-clean
branch
from
7882077
to
ebd188a
Compare
|
@mboes Fixed the CI build and moved the new blags to .bazelrc. (Also fixed the unecessary This is ready for review. |
mboes
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
Looks good. I'd love it if we could identify some version of our dependencies that have no incompatible_* issues. That way we can pin to those for now, drop all exemptions in our .bazelrc, and hence be in a place where we know we won't be introduce any incompatibilities ourselves.
|
Ok. I'll merge this first to prevent any further conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bazel imcompatible changes, more specifically:
Note:
I added the
--incompatiblechecks to the circle CI build to ensure we do not use these deprecated constructions anymore.It might be annoying on the short term but it will save us lot of headaches on the long run.
Part of #489