Avoid binary file corruption in nixpkgs_local_repository #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes #136 `repository_ctx` is meant to work on "text" files and does text encoding and decoding, which breaks in the context of a binary file. There is no `cp` API in repository_ctx, as suggested in bazelbuild/bazel#11858, but bazelbuild/bazel#11857 suggested to use this approach with `repository_ctx.file`.
guibou
changed the title
Merged
thufschmitt
approved these changes
Mar 22, 2021
Co-authored-by: Théophane Hufschmitt <regnat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #136
repository_ctxis meant to work on "text" files and does text encodingand decoding, which breaks in the context of a binary file.
There is no
cpAPI in repository_ctx, as suggested inbazelbuild/bazel#11858, but
bazelbuild/bazel#11857 suggested to use this
approach with
repository_ctx.file.