Output the (column, row) of a patternmatch when outputing at the INFO level #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErinvanderVeen
force-pushed
the
column-row-debug
branch
from
3c38cd1
to
f901807
Compare
ErinvanderVeen
force-pushed
the
column-row-debug
branch
from
f901807
to
e5e19d0
Compare
Xophmeister
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Nice 🙂
I think I personally prefer Ly:x format to (x, y), but that's just bike-shedding. Besides, (x, y) is consistent with elsewhere, so no worries!
That said, this is recalculating the coords every time it spits out logging output, which is a lot. It would definitely be worth memoising pattern_position, if it's straightforward to do so.
Sure. Yeah. I'll do that! |
ErinvanderVeen
force-pushed
the
column-row-debug
branch
from
ff395ce
to
b9a30fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output the (column, row) of a patternmatch when outputing at the INFO level
Issue: #681
Description
This is part one of issue #681, adding the row and column to the debug output while not supporting named patterns yet.
Checklist
Checklist before merging: