Propagate transports #111
Merged
Propagate transports #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes github/webauthn-json#44, which passes through transports information Also updates parcel and adds some fixes for that
As generated by webauthn-json. This allows running the demo server and copy pasting its logs to create new test cases
This is only possible since webauthn-json has recently implemented support for [passing this value](github/webauthn-json#44)
In the server, this result is stored in the database so that it can be passed to future logins via CredentialEntry's
ErinvanderVeen
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since github/webauthn-json#44 the
getTransportsresult is propagated to the JSON registration responses, which we should pass along in the library and store in the database of the demo server. See individual commits for more info. Resolves #108I tested to make sure that the demo server correctly passes this information along by:
getTransports()(yet?)sqlite3 users.sqlite3 'update credential_entries set transports = 2;'), the iPhone can no longer use the security key through NFCsqlite3 users.sqlite3 'update credential_entries set transports = 8;'), the desktop browser can no longer be used to log in