Drop dependency on deriving-aeson; update to Aeson 2 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErinvanderVeen
force-pushed
the
aeson-2
branch
5 times, most recently
from
e48918b
to
bfea952
Compare
infinisil
requested changes
Jan 24, 2022
|
Weird that CI doesn't run. We should definitely make that work since this PR requires compilation of a number of dependencies (with CI we'll have those in the cachix cache). |
|
A workaround to fix CI is to follow this guide to allow running a workflow manually for a branch. |
ErinvanderVeen
force-pushed
the
aeson-2
branch
from
8f83b1d
to
49d42be
Compare
To avoid a name clash, the aeson1 version is named `webauthn_aeson1`.
ErinvanderVeen
force-pushed
the
aeson-2
branch
from
9d09cc7
to
bff4e20
Compare
ErinvanderVeen
force-pushed
the
aeson-2
branch
from
bff4e20
to
6179f56
Compare
infinisil
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping the deriving-aeson dependency keeps compilation times low enough, while still allowing the upgrade to Aeson 2.
Some changes were made to ensure compatibility with Aeson 1.x and 2.x.
Dropping the dependency was due to: fumieval/deriving-aeson#16
Compilation times: