-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly allow the AAGUID extension to be optional in Packed Attestation #174
Correctly allow the AAGUID extension to be optional in Packed Attestation #174
Conversation
The AAGUID extension for packed attestation is specifically marked as optional by the specification. This commit correctly reflects that in the implementation.
f4b314d
to
438c2e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good, but can we also have a test case? Maybe @stephenjudkins has a JSON test case ready to use :D
We should also write release notes here already, this needs to increase the major version due to it being backwards-incompatible
Here's a registration response that should, I believe, exercise this issue. If it doesn't let me know and I'll check out the commit where we were reliably exercising this issue.
|
The AAGUID extension for packed attestation is specifically marked as optional by the specification. This commit correctly reflects that in the implementation.
Resolves #173