Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed TiddlyWiki features that are not relevant to Twine #161

Merged
merged 5 commits into from
Aug 28, 2014

Conversation

mthuurne
Copy link
Contributor

This is a rebased version of the "unwiki" branch from #157.

The tiddlers have various attributes that were useful when TiddlyWiki was actually used as a wiki, but are no longer useful for passage storage in Twine. So I removed them.

Relevant forum discussion: http://twinery.org/forum/index.php/topic,1782.msg4603.html

It was used to specify the 'modifier' attribute for the tiddlers. This
is not used by Twine and as far as I know story formats don't use this
information either. Note this is unrelated to StoryAuthor.
Twee was the only piece of code that could override the default author
but that option was removed.
It was not used anywhere.
It was not used anywhere.
This used to contain the modification date, which was used to keep the
newest of two identically titled tiddlers. Instead of keeping track of
the modification date, we now just keep the latest added version. The
only situation when this could lead to different results is when
building a story with some of the tiddlers coming from an HTML file,
which is not a likely scenario.

Note that Tiddler.__cmp__ was implemented incorrectly, but since it was
used incorrectly as well, the two bugs cancelled each other out.
@webbedspace
Copy link
Member

Sorry for not accepting this earlier.

@webbedspace webbedspace merged commit ba6d752 into tweecode:master Aug 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants