Omit 'tags' attribute for untagged passages #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was used to specify the 'modifier' attribute for the tiddlers. This is not used by Twine and as far as I know story formats don't use this information either. Note this is unrelated to StoryAuthor.
Twee was the only piece of code that could override the default author but that option was removed.
It was not used anywhere.
It was not used anywhere.
This used to contain the modification date, which was used to keep the newest of two identically titled tiddlers. Instead of keeping track of the modification date, we now just keep the latest added version. The only situation when this could lead to different results is when building a story with some of the tiddlers coming from an HTML file, which is not a likely scenario. Note that Tiddler.__cmp__ was implemented incorrectly, but since it was used incorrectly as well, the two bugs cancelled each other out.
This produces slightly smaller and cleaner HTML. Following the lead of TheMadExile, who did the same for TweeGo: http://twinery.org/forum/index.php/topic,1782.msg4657.html#msg4657
webbedspace
added a commit
that referenced
this pull request
Aug 28, 2014
Remove various TiddlyWiki metadata from passages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the last commit really belongs in this pull, but I want to avoid another merge conflict so I based it on
unwiki2rather than onmaster.