Move VERSION inside chipsec/ directory #15
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue chipsec#42.
Without this patch,
python setup.py sdist && pip install dist/chipsec-1.2.3.tar.gz
will die with:With it, it will succeed.
There are still lots of assumptions in the code on where the code and the configuration files resides. For instance,
chipsec_main.py
will use__file__
to search for modules. When installing the packages, the scripts will be installed in another directory (i.e., bin/) and therefore the current code will fail.Ultimately, the code should use pkg_resources from setuptools to solve this issue.