chore: Improve dropdown draggable list #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaPimpalkar
commented
Sep 29, 2023
front/src/modules/ui/menu-item/components/MenuItemDraggable.tsx
Outdated
Show resolved
Hide resolved
AdityaPimpalkar
commented
Sep 29, 2023
front/src/modules/ui/draggable-list/components/DraggableItem.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/ui/draggable-list/components/DraggableItem.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/ui/menu-item/components/MenuItemDraggable.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/ui/menu-item/components/MenuItemDraggable.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/ui/view-bar/components/ViewFieldsVisibilityDropdownSection.tsx
Show resolved
Hide resolved
AdityaPimpalkar
commented
Sep 30, 2023
Comment on lines
+44
to
+46
| background: isDragged | ||
| ? theme.background.transparent.light | ||
| : 'none', |
There was a problem hiding this comment.
I found the css fix on DraggableItem
lucasbordeau
approved these changes
Oct 3, 2023
|
@AdityaPimpalkar Thanks a lot, I have made a few small changes after discussing with the team here: #1874 |
AdityaPimpalkar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1668
Feedback is appreciated! :)