Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Board options edit and reorder #1858

Closed
wants to merge 20 commits into from

Conversation

AdityaPimpalkar
Copy link
Contributor

@AdityaPimpalkar AdityaPimpalkar commented Oct 3, 2023

closes: #818

Tasks

  1. Rendering pipeline stages in options
  2. Waiting for chore: Improve dropdown draggable list #1738 to get merged to add DraggableList on Fields and Stages
  3. Separating onDragEnd logic to avoid duplicated logic
  4. Adding visible/hidden board column states
  5. Adding isVisible column to pipeline_stages on the backend
  6. Creating a new component MenuItemTag which renders Tag inside MenuItem
  7. Render BoardColumnEditTitleMenu on edit

@charlesBochet
Copy link
Member

charlesBochet commented Oct 4, 2023

@AdityaPimpalkar the other PR has been merged! Thanks for all your contributions!

@AdityaPimpalkar AdityaPimpalkar marked this pull request as ready for review October 8, 2023 20:37
@AdityaPimpalkar
Copy link
Contributor Author

AdityaPimpalkar commented Oct 8, 2023

A few issues I am running into:

  • css is being a little weird after adding the DraggableList component
  • isVisible property Is not updating on the backend
  • Edit title component height is overflowing from the screen (maybe we can come up with some other design)
Screen.Recording.2023-10-08.at.9.58.05.PM.mov

Comment on lines +52 to +58
<BoardOptionsContext.Provider
value={{
...opportunitiesBoardOptions,
handleEditColumnTitle: handleEditColumnTitle,
handleDeleteColumn: handlePipelineStageDelete,
}}
>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid too much prop drilling, I passed it into context

Copy link
Contributor Author

@AdityaPimpalkar AdityaPimpalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like some feedback on this as well :)

@charlesBochet charlesBochet self-assigned this Oct 17, 2023
@charlesBochet
Copy link
Member

@AdityaPimpalkar @bosiraphael I've tried to merge it but we are too far now. I'm leaving it open. We will pick and re-use the components once the Board refactoring is completed

@charlesBochet
Copy link
Member

@AdityaPimpalkar We have not forgotten this one! We are getting there, it's likely to be tackled early next week!

@AdityaPimpalkar
Copy link
Contributor Author

Hey @charlesBochet I can re implement this in a new PR if you want, you can close this one because there are too many conflicts

@charlesBochet
Copy link
Member

Thank you @AdityaPimpalkar I'll likely ping you next week then!

@charlesBochet
Copy link
Member

@AdityaPimpalkar, we have changed our product requirement on this one. In the new board implementation, you'll be able to create a board on any object having a field of type SELECT. The existing board is a board of Opportunity on field Stage. Re-ordering and changing the column will be done through Settings > Data model. We don't want to make them editable on the board directly anymore as this would confuse the users to be able to edit opportunity stages in two different places.

Thanks again for the multiple contributions on Twenty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opportunities menu: add and edit stages
3 participants