feat: insert images to notes #1964
Conversation
| // uploadAttachmentMutation({ | ||
| // variables: { | ||
| // file: file, | ||
| // activityId: activity.id, | ||
| // }, | ||
| // }) |
There was a problem hiding this comment.
I am little confused as to which personId and companyId are to be passed, is it the person and their assigned company? or the relations assigned to the note? Thanks!
| @@ -56,7 +56,7 @@ export const RightDrawer = () => { | |||
| useListenClickOutside({ | |||
| refs: [rightDrawerRef], | |||
| callback: () => closeRightDrawer(), | |||
| mode: ClickOutsideMode.absolute, | |||
| mode: ClickOutsideMode.dom, | |||
There was a problem hiding this comment.
Changing this to dom because the drawer was closing when I clicked on upload image
| const bodyContent = JSON.parse(body); | ||
| const parsedTitle = Array.isArray(bodyContent) | ||
| ? bodyContent[0].type !== 'image' | ||
| ? bodyContent[0].content[0]?.text | ||
| : '' | ||
| : ''; |
There was a problem hiding this comment.
Temporarily handling the case if image was added as a first activity (block note does not have a contents property for upload image)
Should the image be displayed on TimelineActivity?
|
@AdityaPimpalkar sorry for the slow review, it has been super busy these days, I'm taking a look tomorrow morning :) |
|
Waiting for activities refactor with custom objects |
|
@bosiraphael :) |
|
Hello @AdityaPimpalkar, thank you very much for your contribution. This issue will be closed by #2872. Unfortunately, we changed many things in the app since your PR has been opened so we will have to close it. |
|
@AdityaPimpalkar Really sorry about not merging your PR! We have changed a lot of things over the last months and were forced to hold on many PRs. Thanks a lot for the help, deeply appreciated :) |
closes: #1878
The image picker is overflowing (not sure if we change it's css)
Feedback is appreciated! :)
Screen.Recording.2023-10-11.at.2.09.35.PM.mov