-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload image for use in blocknote editor #3044
Upload image for use in blocknote editor #3044
Conversation
- fix local-storage not in gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comment @brendanlaschke, thanks as always!
packages/twenty-front/src/modules/activities/components/ActivityBodyEditor.tsx
Outdated
Show resolved
Hide resolved
@brendanlaschke I've found a bug actually. If the image is the first child of the body: I think it's because it has no "content" section. We should update this logic:
I also think we should extract it to an util |
add tests for body parsing notes and tasks
done - also for the similar preview in the notes tab ... |
Completes the work of #1964 to also upload images.
closes #1878
Fixed also local-storage not in gitignore