Microsoft Auth Integration #4718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled support for SignIn through Microsoft Made Password Based Auth Optional with Environment variables Removed unused injections from google-auth.controller.ts
Fixed the Issue where company.ts file had old column name 'address' instead of 'addressAddressCity'
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
|
Oh nice!!! Thank you. We'll review this during the week It means then we'll need to support email and calendar sync for Microsoft which is a heavy work haha 😁. The code is almost stable for Google sync, we're still fixing the last few bits |
martmull
reviewed
Apr 22, 2024
packages/twenty-server/src/engine/core-modules/auth/controllers/microsoft-auth.controller.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/auth/strategies/microsoft.auth.strategy.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/integrations/environment/environment-variables.ts
Outdated
Show resolved
Hide resolved
changed default value for password auth updated docs for environment variable changes update authprovider state default value for password auth
|
@DGamer007 see this pr for the changes I added -> #5103 |
|
PR has been migrated to #5103 |
Weiko
pushed a commit
that referenced
this pull request
Apr 24, 2024
Need to create a new branch because original branch name is `main` and we cannot push additional commits Linked to #4718   --------- Co-authored-by: DGamer007 <prajapatidhruv266@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated Microsoft Authentication flow
Made Password based Auth Optional by providing support for Environment variables for it
A Quick Bugfix for Standard Object Prefill data feature