Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Poor contrast on SlashMenu #5342

Merged
merged 2 commits into from
May 30, 2024
Merged

fix: Poor contrast on SlashMenu #5342

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13b111d
fix: Poor contrast on SlashMenu
its-id May 8, 2024
ea19b52
Merge branch 'main' into fix-#5304
lucasbordeau May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@ const StyledDropdownMenu = styled.div<{
backdrop-filter: ${({ theme, disableBlur }) =>
disableBlur ? 'none' : theme.blur.medium};

color: ${({ theme }) => theme.font.color.secondary};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


background: ${({ theme, disableBlur }) =>
disableBlur
? theme.background.primary
: theme.background.transparent.secondary};
: theme.background.transparent.primary};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the background looks correct according to the ticket (transparent.secondary)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the background looks correct according to the ticket (transparent.secondary)

the current background is more lighter which makes it a bit different in looks when compared to that of menu bars opened when click on table action buttons.

since, the requirement was to make all menu bar follow same theme. that's why i did change the background color as well. (although the bg used in table menus on the left uses theme.background.primary | i went for transparent.primary as we are also having some blur css so wanted to keep its point).

else, i can revert back to original background and show you the difference if you want.


border: ${({ disableBorder, theme }) =>
disableBorder ? 'none' : `1px solid ${theme.border.color.medium}`};
Expand Down