-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Poor contrast on SlashMenu #5342
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,10 +8,12 @@ const StyledDropdownMenu = styled.div<{ | |
backdrop-filter: ${({ theme, disableBlur }) => | ||
disableBlur ? 'none' : theme.blur.medium}; | ||
|
||
color: ${({ theme }) => theme.font.color.secondary}; | ||
|
||
background: ${({ theme, disableBlur }) => | ||
disableBlur | ||
? theme.background.primary | ||
: theme.background.transparent.secondary}; | ||
: theme.background.transparent.primary}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the background looks correct according to the ticket (transparent.secondary) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are we changing this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
the current background is more lighter which makes it a bit different in looks when compared to that of menu bars opened when click on table action buttons. since, the requirement was to make all menu bar follow same theme. that's why i did change the background color as well. (although the bg used in table menus on the left uses theme.background.primary | i went for transparent.primary as we are also having some blur css so wanted to keep its point). else, i can revert back to original background and show you the difference if you want. |
||
|
||
border: ${({ disableBorder, theme }) => | ||
disableBorder ? 'none' : `1px solid ${theme.border.color.medium}`}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1