Add workflow and version as standard object #6412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces workflow and version as standard objects, controlled by a feature flag.
- Added
workflowPrefillDatafunction inpackages/twenty-server/src/database/commands/data-seed-dev-workspace.command.tsfor seeding workflow data. - Introduced
IsWorkflowEnabledfeature flag inpackages/twenty-server/src/database/typeorm-seeds/core/feature-flags.ts. - Updated
FeatureFlagKeysenum inpackages/twenty-server/src/engine/core-modules/feature-flag/feature-flag.entity.tsto includeIsWorkflowEnabled. - Added new entities
WorkflowWorkspaceEntityandWorkflowVersionWorkspaceEntityinpackages/twenty-server/src/modules/workflow/standard-objects/. - Modified multiple files to include new relations to
WorkflowWorkspaceEntity, ensuring integration with existing entities likeActivityTargetWorkspaceEntityandAttachmentWorkspaceEntity.
19 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
thomtrp
force-pushed
the
tt-workflow-and-version-as-standard-objects
branch
from
0bebb4f
to
b87e720
Compare
bosiraphael
reviewed
Jul 25, 2024
There was a problem hiding this comment.
Should this file be empty ?
Comment on lines
+18
to
+29
| @WorkspaceGate({ | ||
| featureFlag: FeatureFlagKeys.IsWorkflowEnabled, | ||
| }) | ||
| @WorkspaceEntity({ | ||
| standardId: STANDARD_OBJECT_IDS.workflowVersion, | ||
| namePlural: 'workflowVersions', | ||
| labelSingular: 'WorkflowVersion', | ||
| labelPlural: 'WorkflowVersions', | ||
| description: 'A workflow version', | ||
| icon: 'IconVersions', | ||
| labelIdentifierStandardId: WORKFLOW_VERSION_STANDARD_FIELD_IDS.name, | ||
| }) |
There was a problem hiding this comment.
I think the gate should be placed below the @WorkspaceEntity
Suggested change
| @WorkspaceGate({ | |
| featureFlag: FeatureFlagKeys.IsWorkflowEnabled, | |
| }) | |
| @WorkspaceEntity({ | |
| standardId: STANDARD_OBJECT_IDS.workflowVersion, | |
| namePlural: 'workflowVersions', | |
| labelSingular: 'WorkflowVersion', | |
| labelPlural: 'WorkflowVersions', | |
| description: 'A workflow version', | |
| icon: 'IconVersions', | |
| labelIdentifierStandardId: WORKFLOW_VERSION_STANDARD_FIELD_IDS.name, | |
| }) | |
| @WorkspaceEntity({ | |
| standardId: STANDARD_OBJECT_IDS.workflowVersion, | |
| namePlural: 'workflowVersions', | |
| labelSingular: 'WorkflowVersion', | |
| labelPlural: 'WorkflowVersions', | |
| description: 'A workflow version', | |
| icon: 'IconVersions', | |
| labelIdentifierStandardId: WORKFLOW_VERSION_STANDARD_FIELD_IDS.name, | |
| }) | |
| @WorkspaceGate({ | |
| featureFlag: FeatureFlagKeys.IsWorkflowEnabled, | |
| }) |
Comment on lines
+24
to
+35
| @WorkspaceGate({ | ||
| featureFlag: FeatureFlagKeys.IsWorkflowEnabled, | ||
| }) | ||
| @WorkspaceEntity({ | ||
| standardId: STANDARD_OBJECT_IDS.workflow, | ||
| namePlural: 'workflows', | ||
| labelSingular: 'Workflow', | ||
| labelPlural: 'Workflows', | ||
| description: 'A workflow', | ||
| icon: 'IconSettingsAutomation', | ||
| labelIdentifierStandardId: WORKFLOW_STANDARD_FIELD_IDS.name, | ||
| }) |
There was a problem hiding this comment.
Same here
Suggested change
| @WorkspaceGate({ | |
| featureFlag: FeatureFlagKeys.IsWorkflowEnabled, | |
| }) | |
| @WorkspaceEntity({ | |
| standardId: STANDARD_OBJECT_IDS.workflow, | |
| namePlural: 'workflows', | |
| labelSingular: 'Workflow', | |
| labelPlural: 'Workflows', | |
| description: 'A workflow', | |
| icon: 'IconSettingsAutomation', | |
| labelIdentifierStandardId: WORKFLOW_STANDARD_FIELD_IDS.name, | |
| }) | |
| @WorkspaceEntity({ | |
| standardId: STANDARD_OBJECT_IDS.workflow, | |
| namePlural: 'workflows', | |
| labelSingular: 'Workflow', | |
| labelPlural: 'Workflows', | |
| description: 'A workflow', | |
| icon: 'IconSettingsAutomation', | |
| labelIdentifierStandardId: WORKFLOW_STANDARD_FIELD_IDS.name, | |
| }) | |
| @WorkspaceGate({ | |
| featureFlag: FeatureFlagKeys.IsWorkflowEnabled, | |
| }) |
| inverseSideFieldKey: 'favorites', | ||
| }) | ||
| @WorkspaceIsNullable() | ||
| workflow: Relation<WorkflowWorkspaceEntity> | null; |
| inverseSideFieldKey: 'attachments', | ||
| }) | ||
| @WorkspaceIsNullable() | ||
| workflow: Relation<WorkflowWorkspaceEntity> | null; |
| inverseSideFieldKey: 'activityTargets', | ||
| }) | ||
| @WorkspaceIsNullable() | ||
| workflow: Relation<WorkflowWorkspaceEntity> | null; |
There was a problem hiding this comment.
You also have to gate the relations
| inverseSideFieldKey: 'timelineActivities', | ||
| }) | ||
| @WorkspaceIsNullable() | ||
| workflow: Relation<WorkflowWorkspaceEntity> | null; |
charlesBochet
added a commit
that referenced
this pull request
Jul 25, 2024
We have recently merged [#workflow](#6412) but we should put the workflow standard object behind a feature flag for now --------- Co-authored-by: bosiraphael <raphael.bosi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title
Hidden behind a feature flag.