-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple fitrep comparison #51
Conversation
- Enable holding multiple FitReps in memory
- Fixed buggy label on bars - Added rank dividing line for comparison mode - Added Name Hovering highlights - Fixed Table Multi row Editting - Updated Flatpickr to work with Redux
I'm getting webpack errors. Have a new laptop and just got everything re-installed and am able to
|
@twgardner2 Probably the node version. Use 16.13.2 (forgot to mention that) or 18.15 -- figured we were due to jump to one of the current LTS. |
|
Looks like you're missing some node_modules Have you run |
yeah, I think that's the problem (missing modules, that is). I've run Here is without options:
|
What's your |
I just installed
|
Could be that the issue is on python 3.11. Is there an easy way for you to downgrade to 3.10? |
I should be able to do that. I'm using |
Dude, that was it! Ok, I have your branch up and running. I see the dashed yellow box, but what does it do? |
OK, in parallel, and reviewing the code a bit more I went ahead and ran The dashed yellow box should be around "Sample-I-AM" the name of our sample sailor. Once you start to upload multiple Fitreps, the yellow box(es) become consequential/useful. (Sample gets clobbered on the first upload, assuming no one really cares about the sample) |
|
Ah, I did upload another FITREP expecting it to do something, but I need to upload 2? |
yup -- 2 real(ish) ones |
Oh wow, that's doing a lot of stuff! I gotta go eat dinner, but will check it out some more. |
Oh, also looks like a test is failing... |
Yeah, that makes sense -- node 12 should probably be dropped from the test list. |
Also, If you haven't already, I strongly recommend adding Redux DevTools to your browser. With this latest rev, it will let you monitor the state and its changes as you interact with the app. |
@twgardner2 Heads up: found and fixed a bug on this PR -- this branch's head is now at commit 0c03df0 |
Oh nice. Squashing bugs. I've been really bad about reviewing this, but I
promise I've looked at it. I think it's really cool that you've made it
work, but I keep trying to think of a way to make the actual comparison
more visually clear. There's probably just a ceiling to how well you can
discern multiple PSRs while looking at them simultaneously. What would you
think about the multiple PSR feature just showing the normal viz but adding
them vertically?
…On Mon, Apr 3, 2023 at 12:33 PM ChaseWPDEV ***@***.***> wrote:
@twgardner2 <https://github.com/twgardner2> Heads up: found and fixed a
bug on this PR -- this branch's head is now at commit 0c03df0
<0c03df0>
—
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJVYJ74UXVHHEXW3XIKWL3W7L3WVANCNFSM6AAAAAAVVXZI5U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@twgardner2 What if, on the overlay comparison mode, I add the associated last name just to the right of the last fitrep bullet? I could also have it fade in/ fade out along with the rest of that individual's graph. |
I think that would help. I'm basically onboard with merging, but I think I found some buggy behavior, let me know if that's what this is: Steps to replicate:
When I hover over the second PSR's chicklet, it brings its data to the forefront, but hovering over the first one doesn't do so. Is that on purpose? |
Bug fixed and tailing last name added. I also realized it probably not obvious that you can toggle records on/off in the multi-comparison view by clicking on the chicklet (good for quickly moving around between 3 or more), working on a way to make that more obvious. |
@twgardner2 Toggle indicator for Multi view added. I think this (might) bring us up to a release candidate on this one. |
Ok, I may have found two more things:
|
-Hide rep_sen_rg_g with other bars
@twgardner2 Right you are:
|
-Fix single-multi toggle with hidden records
aaaannnnddd... a fix to the chicklets breaking after a lot of toggling (had to do with trying to recover from an empty data set) |
You're a machine! |
Implementation of MultiFitrep compairson mode. Alongside some additional fixes with the Redux implementation.