Add (simple) {% raw %} implementation... #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a good first implementation to me. Aside from the whitespace issue you mention, it may be possible to create a template with "{% raw %}" and "{% endraw %}" in strings that might break, but it's enough of an edge case that I don't think it's likely to affect anyone. Thanks for the contribution! |
justjohn
added a commit
that referenced
this pull request
Mar 18, 2013
Add (simple) {% raw %} implementation...
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well...this is really a simple implementation ;) however it works and not having {% raw %} at hand really drives me mad as my templates contain angularjs code. Currently my workaround is
{{ '{{' }} angular.var {{ '}}' }}
The only real problem with my implementation i see (i might of course be missing something ;) ) is that you have to type {% raw %} EXACTLY like this. Otherwise the parsing must be changed to support regexes for the tokens.